Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix-14601][UI] Ironed out the issue with choosing an environment on the task form of both types of DMS and DATASYNC. #14605

Merged
merged 9 commits into from
Jul 20, 2023

Conversation

calvinjiang
Copy link
Contributor

Purpose of the pull request

This PR will close #14601 .

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@github-actions github-actions bot added the UI ui and front end related label Jul 20, 2023
@calvinjiang calvinjiang added bug Something isn't working 3.2.0 for 3.2.0 version labels Jul 20, 2023
@calvinjiang calvinjiang added this to the 3.2.0 milestone Jul 20, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2023

Codecov Report

Merging #14605 (d7383b2) into dev (3d033da) will increase coverage by 0.04%.
The diff coverage is n/a.

❗ Current head d7383b2 differs from pull request most recent head 50020fc. Consider uploading reports for the commit 50020fc to get more accurate results

@@             Coverage Diff              @@
##                dev   #14605      +/-   ##
============================================
+ Coverage     38.46%   38.51%   +0.04%     
- Complexity     4561     4566       +5     
============================================
  Files          1260     1260              
  Lines         43793    43793              
  Branches       4833     4833              
============================================
+ Hits          16844    16865      +21     
+ Misses        25079    25052      -27     
- Partials       1870     1876       +6     

see 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Jul 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@calvinjiang calvinjiang merged commit fc65c18 into apache:dev Jul 20, 2023
zhuangchong pushed a commit that referenced this pull request Aug 2, 2023
…the task form of both types of DMS and DATASYNC. (#14605)

* worked out this issue
biaoma-ty pushed a commit to Kasma-Inc/dolphinscheduler that referenced this pull request Aug 17, 2023
…the task form of both types of DMS and DATASYNC. (apache#14605)

* worked out this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.2.0 for 3.2.0 version bug Something isn't working ready-to-merge UI ui and front end related
Projects
None yet
4 participants