Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix-14517][api] An error occurred while trying to access the Postgres data… #14574

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

hoey94
Copy link
Contributor

@hoey94 hoey94 commented Jul 18, 2023

Purpose of the pull request

This pull request fix #14517

Brief change log

old code:

if (dataSource.getType() == DbType.POSTGRESQL) {
    rs = connection.createStatement().executeQuery(Constants.DATABASES_QUERY_PG);
} 
rs = connection.createStatement().executeQuery(Constants.DATABASES_QUERY);

new code:

if (dataSource.getType() == DbType.POSTGRESQL) {
    rs = connection.createStatement().executeQuery(Constants.DATABASES_QUERY_PG);
} else {
    rs = connection.createStatement().executeQuery(Constants.DATABASES_QUERY);
}

Verify this pull request

This change can be verified as follows:

Manually verified the change by testing locally.

@SbloodyS SbloodyS added bug Something isn't working 3.2.0 for 3.2.0 version labels Jul 18, 2023
@SbloodyS SbloodyS added this to the 3.2.0 milestone Jul 18, 2023
@SbloodyS SbloodyS added the first time contributor First-time contributor label Jul 18, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 18, 2023

Codecov Report

Merging #14574 (c34430d) into dev (9d10de6) will increase coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head c34430d differs from pull request most recent head e00c467. Consider uploading reports for the commit e00c467 to get more accurate results

@@             Coverage Diff              @@
##                dev   #14574      +/-   ##
============================================
+ Coverage     38.66%   38.68%   +0.01%     
- Complexity     4575     4578       +3     
============================================
  Files          1241     1241              
  Lines         43569    43569              
  Branches       4826     4826              
============================================
+ Hits          16848    16854       +6     
+ Misses        24850    24848       -2     
+ Partials       1871     1867       -4     
Impacted Files Coverage Δ
...eduler/api/service/impl/DataSourceServiceImpl.java 50.83% <0.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Jul 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@SbloodyS SbloodyS merged commit 1ba0aec into apache:dev Jul 18, 2023
zhongjiajie pushed a commit that referenced this pull request Jul 20, 2023
biaoma-ty pushed a commit to Kasma-Inc/dolphinscheduler that referenced this pull request Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.2.0 for 3.2.0 version backend bug Something isn't working first time contributor First-time contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [dolphinscheduler-api] An error occurred while trying to access the Postgres database.
3 participants