Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use convert to set the exist column collate to utf8_bin #13479

Merged

Conversation

ruanwenjun
Copy link
Member

@ruanwenjun ruanwenjun commented Feb 1, 2023

Purpose of the pull request

Use alter table QRTZ_BLOB_TRIGGERS collate = utf8mb4_bin; will not update the exist column.
Use ALTER TABLE QRTZ_BLOB_TRIGGERS CONVERT TO CHARACTER SET utf8 COLLATE utf8_bin; will update the exist column.

This PR is supplementary for #13469

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@ruanwenjun ruanwenjun added the 3.2.0 for 3.2.0 version label Feb 1, 2023
@ruanwenjun ruanwenjun added this to the 3.2.0 milestone Feb 1, 2023
@ruanwenjun ruanwenjun added the improvement make more easy to user or prompt friendly label Feb 1, 2023
Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@sonarcloud
Copy link

sonarcloud bot commented Feb 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ruanwenjun ruanwenjun merged commit af9091a into apache:dev Feb 1, 2023
@ruanwenjun ruanwenjun deleted the dev_wenjun_updateTheColumnCollate branch February 1, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.2.0 for 3.2.0 version backend improvement make more easy to user or prompt friendly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants