-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improvement][Worker] Startup parameter should have the highest priority #13274
[Improvement][Worker] Startup parameter should have the highest priority #13274
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #13274 +/- ##
============================================
- Coverage 39.53% 39.51% -0.03%
+ Complexity 4293 4288 -5
============================================
Files 1072 1072
Lines 40558 40551 -7
Branches 4670 4668 -2
============================================
- Hits 16035 16022 -13
- Misses 22741 22746 +5
- Partials 1782 1783 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Would u like to double check when available? Thanks : ) @JinyLeeChina @caishunfeng @zhongjiajie
Purpose of the pull request
Brief change log
dx
, another parameter(local or global)dy
set the value ${dx}aaa,dx
will be replaced by global parameter which has the lower priority. In addition, in every task, parameter placeholders will be replaced, either. Like in shell task:paramParsingPreparation
.Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md