Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc][datasource-12820] add azure sql database doc #13254

Merged
merged 4 commits into from
Dec 22, 2022

Conversation

Tianqi-Dotes
Copy link
Member

Purpose of the pull request

#12820

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

Copy link
Member

@zhongjiajie zhongjiajie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should avoid using Chinese pic in our docs, please remove or replace docs/img/new_ui/dev/datasource/azuresql-token.png.png

Other LGTM

@Tianqi-Dotes
Copy link
Member Author

we should avoid using Chinese pic in our docs, please remove or replace docs/img/new_ui/dev/datasource/azuresql-token.png.png

Other LGTM

deleted,thanx

@Tianqi-Dotes Tianqi-Dotes added this to the 3.2.0 milestone Dec 22, 2022
@Tianqi-Dotes Tianqi-Dotes added the 3.2.0 for 3.2.0 version label Dec 22, 2022
caishunfeng
caishunfeng previously approved these changes Dec 22, 2022
Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tianqi-Dotes Tianqi-Dotes merged commit 06b77b3 into apache:dev Dec 22, 2022
@Tianqi-Dotes Tianqi-Dotes deleted the doc/sql branch December 22, 2022 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.2.0 for 3.2.0 version document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants