Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix-#12932] when subprocess's processInstance is fail,not notify parent processInstance #12933

Merged
merged 1 commit into from
Nov 22, 2022

Conversation

fuchanghai
Copy link
Member

@fuchanghai fuchanghai commented Nov 18, 2022

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

this close : #12932

@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2022

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 39.32%. Comparing base (401fb4e) to head (71837f8).
Report is 1049 commits behind head on dev.

Files with missing lines Patch % Lines
...erver/master/runner/WorkflowExecuteThreadPool.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##                dev   #12933   +/-   ##
=========================================
  Coverage     39.31%   39.32%           
  Complexity     4247     4247           
=========================================
  Files          1061     1061           
  Lines         40050    40051    +1     
  Branches       4604     4604           
=========================================
+ Hits          15746    15749    +3     
+ Misses        22524    22520    -4     
- Partials       1780     1782    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Nov 18, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@EricGao888 EricGao888 added bug Something isn't working priority:high labels Nov 19, 2022
@EricGao888 EricGao888 added this to the 3.2.0 milestone Nov 19, 2022
@EricGao888 EricGao888 added the 3.2.0 for 3.2.0 version label Nov 19, 2022
@fuchanghai
Copy link
Member Author

@caishunfeng @SbloodyS @ruanwenjun PTAL

Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
BTW, the subprocess task of parent workflow will check at intervals by StateWheelExecuteThread.

@caishunfeng caishunfeng merged commit 3747029 into apache:dev Nov 22, 2022
@fuchanghai fuchanghai deleted the fix-#12932 branch November 30, 2022 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.2.0 for 3.2.0 version backend bug Something isn't working priority:high
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [Master] when subprocess's processInstance is fail,not notify parent processInstance
4 participants