Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix-#12875]command line that -Dmaven.test.skip=true have no effect #12876

Merged
merged 1 commit into from
Nov 13, 2022

Conversation

fuchanghai
Copy link
Member

command line that -Dmaven.test.skip=true have no effect

Purpose of the pull request

Brief change log

command line that -Dmaven.test.skip=true have no effect

Verify this pull request

This pull request is code cleanup without any test coverage.

…e no effect

command line that ``` -Dmaven.test.skip=true```  have no effect
@codecov-commenter
Copy link

Codecov Report

Merging #12876 (f433cdc) into dev (87a88e3) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head f433cdc differs from pull request most recent head 1debacc. Consider uploading reports for the commit 1debacc to get more accurate results

@@             Coverage Diff              @@
##                dev   #12876      +/-   ##
============================================
- Coverage     39.27%   39.27%   -0.01%     
  Complexity     4231     4231              
============================================
  Files          1051     1051              
  Lines         39849    39817      -32     
  Branches       4585     4567      -18     
============================================
- Hits          15652    15637      -15     
+ Misses        22422    22410      -12     
+ Partials       1775     1770       -5     
Impacted Files Coverage Δ
...r/plugin/registry/zookeeper/ZookeeperRegistry.java 43.54% <0.00%> (-6.46%) ⬇️
...hinscheduler/plugin/alert/script/ScriptSender.java 70.58% <0.00%> (-1.64%) ⬇️
...r/plugin/task/sqoop/parameter/SqoopParameters.java 51.19% <0.00%> (-1.20%) ⬇️
...cheduler/plugin/alert/dingtalk/DingTalkSender.java 34.13% <0.00%> (-0.78%) ⬇️
...rver/master/runner/task/BlockingTaskProcessor.java 75.86% <0.00%> (-0.55%) ⬇️
...inscheduler/plugin/registry/etcd/EtcdRegistry.java 50.69% <0.00%> (-0.35%) ⬇️
.../dolphinscheduler/plugin/task/datax/DataxTask.java 36.62% <0.00%> (-0.26%) ⬇️
.../dolphinscheduler/plugin/task/spark/SparkTask.java 72.56% <0.00%> (-0.25%) ⬇️
...dolphinscheduler/service/storage/impl/S3Utils.java 0.00% <0.00%> (ø)
...eduler/api/dto/workflow/WorkflowCreateRequest.java 100.00% <0.00%> (ø)
... and 17 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Nov 12, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To future reviewers and maybe the original author who adds the skip, you can use -DskipTests to skip running tests but still compile them, and -Dmaven.test.skip to entirely skip compiling the tests, there is no need to hardcode the skip=false in the pom.xml

@kezhenxu94 kezhenxu94 added the 3.2.0 for 3.2.0 version label Nov 13, 2022
@kezhenxu94 kezhenxu94 added this to the 3.2.0 milestone Nov 13, 2022
@kezhenxu94 kezhenxu94 added the minor Chore Chores about the project, like code clean, typo, etc. label Nov 13, 2022
@kezhenxu94 kezhenxu94 merged commit feb0770 into apache:dev Nov 13, 2022
@fuchanghai fuchanghai deleted the fix-#12875 branch February 16, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.2.0 for 3.2.0 version minor Chore Chores about the project, like code clean, typo, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants