[Improvement-12853][UT] Improve the ut of ResourcePermissionCheckServiceTest #12854
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Currently, the
ResourcePermissionCheckService
is not well tested by the UT ofResourcePermissionCheckServiceTest
because the object under test (i.e.,resourcePermissionCheckService
) is mocked byMockito
. The code logic ofresourcePermissionCheckService
is not covered by UT.dolphinscheduler/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/permission/ResourcePermissionCheckServiceTest.java
Lines 58 to 59 in 775b3f8
dolphinscheduler/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/permission/ResourcePermissionCheckServiceTest.java
Lines 68 to 75 in 775b3f8
Brief change log
ResourcePermissionCheckServiceTest
Verify this pull request
covered by UT