[fix#12195] Change date to timestamp to support cross diff time zones #12239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarkAssassinator
requested review from
caishunfeng,
SbloodyS,
zhuangchong and
ruanwenjun
as code owners
Codecov Report
@@ Coverage Diff @@
## dev #12239 +/- ##
============================================
+ Coverage 39.71% 39.72% +0.01%
- Complexity 4187 4191 +4
============================================
Files 1016 1016
Lines 38044 38049 +5
Branches 4365 4365
============================================
+ Hits 15110 15116 +6
+ Misses 21190 21186 -4
- Partials 1744 1747 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Kudos, SonarCloud Quality Gate passed! |
xdu-chenrj
pushed a commit
to xdu-chenrj/dolphinscheduler
that referenced
this pull request
Oct 13, 2022
…apache#12239) * fix DS support cross time zone, use timestamp replace date
fuchanghai
pushed a commit
to fuchanghai/dolphinscheduler
that referenced
this pull request
Nov 16, 2022
…apache#12239) * fix DS support cross time zone, use timestamp replace date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
fix #12195
Brief change log
Change date to timestamp in
TaskExecutionContextChange date to timestamp in
TaskExecuteResultCommandandTaskExecuteRunningCommandChange all set and get.
Change UT
Add
timeStamp2Dateanddate2TimeStamputils function.Verify this pull request
This pull request is already covered by existing tests