Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alert_send_status may throw duplicate key exception and add limit for query alert #11953

Merged
merged 1 commit into from
Sep 16, 2022

Conversation

ruanwenjun
Copy link
Member

Purpose of the pull request

  • When alert server restart, the alert send status may already insert into db but the alert status doesn't update, then the alert may be execute again, and will insert a duplicate alert send status in db cause duplicate unique key exception

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@sonarcloud
Copy link

sonarcloud bot commented Sep 15, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

6.5% 6.5% Coverage
0.0% 0.0% Duplication

@ruanwenjun ruanwenjun merged commit 4ad3448 into apache:dev Sep 16, 2022
xdu-chenrj pushed a commit to xdu-chenrj/dolphinscheduler that referenced this pull request Sep 17, 2022
@caishunfeng caishunfeng modified the milestones: 3.1.0, 3.2.0 Sep 19, 2022
xdu-chenrj pushed a commit to xdu-chenrj/dolphinscheduler that referenced this pull request Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants