Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] [Doc] Website dead link checker will failed when add new picture's link #7642

Closed
2 of 3 tasks
zhongjiajie opened this issue Dec 27, 2021 · 5 comments
Closed
2 of 3 tasks
Labels
bug Something isn't working document good first issue good first issue priority:low

Comments

@zhongjiajie
Copy link
Member

Search before asking

  • I had searched in the issues and found no similar issues.

What happened

When we add a new picture and add a link for it, our dead link checker would fail. see apache/dolphinscheduler-website#594 (comment) for more detail. I think we should fix this edge case.

What you expected to happen

Should not fail when I add new pic and link

How to reproduce

Add new pic and link

Anything else

No response

Version

dev

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@zhongjiajie zhongjiajie added bug Something isn't working help wanted Extra attention is needed good first issue good first issue labels Dec 27, 2021
@github-actions
Copy link

Hi:

  • Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
  • In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
  • If you haven't received a reply for a long time, you can subscribe to the developer's email,Mail subscription steps reference https://dolphinscheduler.apache.org/en-us/community/development/subscribe.html ,Then write the issue URL in the email content and send question to [email protected].

@github-actions
Copy link

github-actions bot commented Feb 5, 2022

This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.

@zhongjiajie
Copy link
Member Author

remove stale

@github-actions github-actions bot removed the Stale label Feb 8, 2022
@rinkydevi
Copy link

hey @zhongjiajie i would like to work on this project

@zhongjiajie
Copy link
Member Author

Hi @rinkydevi , thanks for your feedback, but we have already fixed this in apache/dolphinscheduler-website#676. you could still find task in #5689 for your first PR to Dolphinscheduler

Repository owner moved this from Todo to Done in DolphinScheduler Roadmap Mar 7, 2022
@zhongjiajie zhongjiajie removed the help wanted Extra attention is needed label Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working document good first issue good first issue priority:low
Projects
Status: Done
Development

No branches or pull requests

3 participants