Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement][Api] Split ProcessService into several service #6867

Closed
2 of 3 tasks
HomminLee opened this issue Nov 16, 2021 · 1 comment
Closed
2 of 3 tasks

[Improvement][Api] Split ProcessService into several service #6867

HomminLee opened this issue Nov 16, 2021 · 1 comment
Labels
feature new feature Waiting for reply Waiting for reply

Comments

@HomminLee
Copy link
Contributor

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

In ProcessService, there is too much logic code, also include many methods which logic is simple.
This violates the single-responsibility principle, and it‘s not easy to maintain.
So it is recommended to split ProcessService into CommandService、ProcessDefinitionService、ProcessInstanceService、TaskService.
More detail see #5546

Use case

No response

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@HomminLee HomminLee added feature new feature Waiting for reply Waiting for reply labels Nov 16, 2021
@github-actions
Copy link

Hi:

  • Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
  • In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
  • If you haven't received a reply for a long time, you can subscribe to the developer's email,Mail subscription steps reference https://dolphinscheduler.apache.org/en-us/community/development/subscribe.html ,Then write the issue URL in the email content and send question to [email protected].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature new feature Waiting for reply Waiting for reply
Projects
None yet
Development

No branches or pull requests

1 participant