[Improvement][Api] Adding transaction when update process definition

[ruanwenjun]

Describe the question
When we update a process definition, we need to perform multiple DML operations, it is needed to add transaction to ensure the data is consistent when an exception occurs.

dolphinscheduler/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java

Line 375 in 842c540

public Map<String, Object> updateProcessDefinition(User loginUser,

dolphinscheduler/dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java

Line 2228 in 842c540

public int saveProcessDefinition(User operator, Project project, String name, String desc, String locations,

There are also some other method need to check, such as:

dolphinscheduler/dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java

Line 2367 in 842c540

public void saveTaskRelation(User operator, ProcessTaskRelation processTaskRelation) {

dolphinscheduler/dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java

Line 2376 in 842c540

public int saveTaskDefinition(User operator, Long projectCode, TaskNode taskNode, TaskDefinition taskDefinition) {

Which version of DolphinScheduler:
-[dev]

Describe alternatives you've considered
Add transaction, and it is recommended to split ProcessService into CommandService、ProcessDefinitionService、ProcessInstanceService、TaskService

[ji04xiaogang]

I would like to contribute to this.

[HomminLee]

I want to take this issue.

[brave-lee]

@ruanwenjun Please confirm that the current interface already supports transactions

[HomminLee]

@ruanwenjun I have a question. Class ProcessService exists in project [dolphinscheduler-service], and there are already exists ProcessDefinitionService、ProcessInstanceService、TaskInstanceService in project [dolphinscheduler-api]. In my previous thoughts, I want split ProcessService to those service class. But I found ProcessService also be used by project [dolphinscheduler-server]. If I follow the previous ideas to complete, the project [dolphinscheduler-api] cannot use those service, this is unacceptable.
So, do you have any suggestions? Should I just create 4 new class in project [dolphinscheduler-service] with other names?

[ruanwenjun]

@HomminLee You can create a new issue to track your idea.

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.

[github-actions]

This issue has been closed because it has not received response for too long time. You could reopen it if you encountered similar problems in the future.