Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DSIP-][SDK] Java SDK #16735

Open
2 tasks done
Dyqer opened this issue Oct 24, 2024 · 4 comments
Open
2 tasks done

[DSIP-][SDK] Java SDK #16735

Dyqer opened this issue Oct 24, 2024 · 4 comments
Labels

Comments

@Dyqer
Copy link
Contributor

Dyqer commented Oct 24, 2024

Search before asking

  • I had searched in the DSIP and found no similar DSIP.

Motivation

I think we need to create a new module, perhaps called dolphinscheduler-spec, and move all the POJO objects from the task-api, registry-api, datasource-api, and dolphinscheduler-api modules into this new module. This way, we can easily create a Java SDK for external use.

Design Detail

dolphinsheduler-spec
+- dolphinsheduler-task-api
+- dolphinsheduler-registry-api
+- dolphinsheduler-datasource-api
+- dolphinsheduler-scheduler-api

Compatibility, Deprecation, and Migration Plan

No response

Test Plan

No response

Code of Conduct

@Dyqer Dyqer added DSIP Waiting for reply Waiting for reply labels Oct 24, 2024
@Dyqer Dyqer changed the title [DSIP-][SDK] DSIP title [DSIP-][SDK] Java SDK Oct 24, 2024
@SbloodyS SbloodyS added discussion discussion and removed Waiting for reply Waiting for reply labels Oct 24, 2024
@SbloodyS
Copy link
Member

SbloodyS commented Oct 24, 2024

I think we need to create a new module, perhaps called dolphinscheduler-spec, and move all the POJO objects from the task-api, registry-api, datasource-api, and dolphinscheduler-api modules into this new module. This way, we can easily create a Java SDK for external use.

dolphinsheduler-spec
+- dolphinsheduler-task-api
+- dolphinsheduler-registry-api
+- dolphinsheduler-datasource-api
+- dolphinsheduler-scheduler-api

I don't see how this is related to JAVA SDK. Please describe clearly what you want firstly. Then the design scheme.

@davidzollo
Copy link
Contributor

I also can't find out the relationship between jdk and pojo

@Dyqer
Copy link
Contributor Author

Dyqer commented Oct 28, 2024

@SbloodyS Sb @davidzollo da
For the SDK, we need to share base classes with SDK users, such as ProcessDefinition, DEPENDENT task, K8s task, and Schedule. If we can move these classes to a common API module, this module can then be reused by both the SDK module and the Master/Worker modules.

Of course, we can create some DTO classes, but we also need to plan for creating DTOs for future classes.

@liunaijie
Copy link
Member

I think what you want to say is:
move project's POJO class to a splited module, then the system out of DS can import this module and use those POJO, am I right?
Maybe you can update the title then we can understand more easily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants