[Bug] [setValue] if "\n" in variable, then setValue function will work bad

[kevinkelin]

Search before asking

• I had searched in the issues and found no similar issues.

What happened

In python task , if a variable has "\n"， then use setValue to make a Parameter for next node, the variable will not work well

node_one

s = "hello \n world"
print("${setValue(message=%s)}"%s)

node_two

echo "${message}"

echo "hi"

check runtime log

node_one

[INFO] 2023-11-08 10:51:02.588 +0800 - process start, process id is: 10376
[INFO] 2023-11-08 10:51:03.588 +0800 -  -> 
	 world)}
[INFO] 2023-11-08 10:51:03.590 +0800 - process has exited. execute 

node_two

[INFO] 2023-11-08 10:51:04.374 +0800 - process start, process id is: 30190
[INFO] 2023-11-08 10:51:05.374 +0800 -  -> 
	
	hi
[INFO] 2023-11-08 10:51:05.375 +0800 - process has exited. execute

What you expected to happen

In node_two, when echo "${message}" will show the Parameter set in pre task, in this case, want show “hello \n world"

How to reproduce

create a workflow, the first task use python task, make a variable include "\n", then use setValue to make a Parameter

Anything else

No response

Version

3.2.x

Are you willing to submit PR?

• Yes I am willing to submit a PR!

Code of Conduct

• I agree to follow this project's Code of Conduct

[Radeity]

Hi @kevinkelin , according to the above logs of node_one, seems like it doesn't print ${setValue(key=value}.

[kevinkelin]

Hi @kevinkelin , according to the above logs of node_one, seems like it doesn't print ${setValue(key=value}.

if setValue work well, there will not print any thing, but in this case, it print world)}

[Radeity]

Hi @kevinkelin , according to the above logs of node_one, seems like it doesn't print ${setValue(key=value}.

if setValue work well, there will not print any thing, but in this case, it print world)}

You should make sure ${setValue(key=value} exists in stdout of node_one.

[kevinkelin]

Hi @kevinkelin , according to the above logs of node_one, seems like it doesn't print ${setValue(key=value}.

if setValue work well, there will not print any thing, but in this case, it print world)}

You should make sure ${setValue(key=value} exists in stdout of node_one.

I resolve this issue

node_one

s = "hello \n world"
print("${setValue(message=%s)}"%repr(s))

node_two

echo "${message}"

echo "hi"

In node_onw, python task must use repr(s) for formating string

so consider about how to optimize this Issue.

[Radeity]

You're right, actually, the cause of the issue is that we find output parameter in a single line, so in your resolution, use repr to read \n, then in stdout, this line will be ${setValue(message=hello \n world)}.

if (line.startsWith("${setValue(") || line.startsWith("#{setValue(")) {
    varPool.append(findVarPool(line));
    varPool.append("$VarPool$");
}

I think we don't have to fix it, instead, we can declare more clearly in our doc, WDYT?

[kevinkelin]

You're right, actually, the cause of the issue is that we find output parameter in a single line, so in your resolution, use repr to read \n, then in stdout, this line will be ${setValue(message=hello \n world)}.

if (line.startsWith("${setValue(") || line.startsWith("#{setValue(")) {
    varPool.append(findVarPool(line));
    varPool.append("$VarPool$");
}

I think we don't have to fix it, instead, we can declare more clearly in our doc, WDYT?

I think is OK, make doc clearly, so that users can avoid this problem.

[Radeity]

Would you like to help enhance the doc? @kevinkelin

[kevinkelin]

Would you like to help enhance the doc? @kevinkelin

OK， how to enhance the doc?

[Radeity]

You can submit PR to this repo, ref #15028