Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DSIP-23][TaskPlugin] Add Lifecycle method to TaskPlugin #14877

Open
3 tasks done
Tracked by #14102
ruanwenjun opened this issue Sep 7, 2023 · 0 comments
Open
3 tasks done
Tracked by #14102

[DSIP-23][TaskPlugin] Add Lifecycle method to TaskPlugin #14877

ruanwenjun opened this issue Sep 7, 2023 · 0 comments
Labels
DSIP improvement make more easy to user or prompt friendly

Comments

@ruanwenjun
Copy link
Member

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

Right now, we have define some methods at the Task plugin, e.g. init, handle, cancel.

There are no close methods, so it's not convenient if we need to close some resource after the task plugin executes.

So it's needed to add Lifecycle interface to do this.

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct
@ruanwenjun ruanwenjun added improvement make more easy to user or prompt friendly Waiting for reply Waiting for reply DSIP and removed Waiting for reply Waiting for reply labels Sep 7, 2023
@ruanwenjun ruanwenjun changed the title [Improvement][TaskPlugin] Add Lifecycle method to TaskPlugin [DSIP-23][TaskPlugin] Add Lifecycle method to TaskPlugin Oct 23, 2023
This was referenced Jan 16, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
DSIP improvement make more easy to user or prompt friendly
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ruanwenjun