Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement][Worker] Startup parameter should have the highest priority #13269

Closed
3 tasks done
Radeity opened this issue Dec 23, 2022 · 2 comments · Fixed by #13274
Closed
3 tasks done

[Improvement][Worker] Startup parameter should have the highest priority #13269

Radeity opened this issue Dec 23, 2022 · 2 comments · Fixed by #13274
Assignees
@Radeity
Labels
backend improvement make more easy to user or prompt friendly

Comments

@Radeity
Copy link
Member

Radeity commented Dec 23, 2022

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

Current parameter priority is Local Parameter > Parameter Context > Global Parameter. When running a new process, user defined startup parameters simply overwrite global parameters, local parameters still have the highest priority.

In fact, we should set startup parameter the highest priority so that task's local parameters can be overwritten if user set startup parameters with the same name. The priority should be Startup Parameter > Local Parameter > Parameter Context > Global Parameter.

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct
@Radeity Radeity added improvement make more easy to user or prompt friendly Waiting for reply Waiting for reply labels Dec 23, 2022
@github-actions
Copy link

Thank you for your feedback, we have received your issue, Please wait patiently for a reply.

  • In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
  • If you haven't received a reply for a long time, you can join our slack and send your question to channel #troubleshooting

@Radeity
Copy link
Member Author

Radeity commented Dec 23, 2022

cc @JinyLeeChina

@Radeity Radeity mentioned this issue Dec 25, 2022
Merged
@SbloodyS SbloodyS added backend and removed Waiting for reply Waiting for reply labels Dec 26, 2022
@Radeity Radeity mentioned this issue Dec 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Radeity Radeity

Labels
backend improvement make more easy to user or prompt friendly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Improvement][Worker] Startup parameter should have the highest priority Radeity/dolphinscheduler
2 participants
@SbloodyS @Radeity