Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement][Master] Validate same content of input file when using task cache #13223

Closed
3 tasks done
Radeity opened this issue Dec 19, 2022 · 3 comments · Fixed by #13298
Closed
3 tasks done

[Improvement][Master] Validate same content of input file when using task cache #13223

Radeity opened this issue Dec 19, 2022 · 3 comments · Fixed by #13298
Assignees
Labels
improvement make more easy to user or prompt friendly

Comments

@Radeity
Copy link
Member

Radeity commented Dec 19, 2022

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

Task cache mechanism is introduced in #13194. Cache key can make sure tasks have the same value of property (store resource path in file paramter), but the same resource path doesn't mean the same file contents. Also, the different resource path may have same content.

For other types of parameter, the same value of property means the same input, keep logic consistency for file parameter, we should check the same content in resourcePath.

Maybe we can add checksum of input file when generating cache key. In addition, i think it's improper to download the whole file in master, we can save checksum in another file when uploading output file, download checksum file when generating cache key.

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@Radeity Radeity added improvement make more easy to user or prompt friendly Waiting for reply Waiting for reply labels Dec 19, 2022
@Radeity
Copy link
Member Author

Radeity commented Dec 19, 2022

@jieguangzhou PTAL.

@github-actions
Copy link

Thank you for your feedback, we have received your issue, Please wait patiently for a reply.

  • In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
  • If you haven't received a reply for a long time, you can join our slack and send your question to channel #troubleshooting

@jieguangzhou
Copy link
Member

@jieguangzhou PTAL.

The file output using file parameter will not change if the user does not manually modify the resource center.

Users should not modify the task output files in the file parameter feature, It's the mechanism inside ds.

But if we use the files parameters from SCP or s3 (If we support them in the future), I think testing is better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement make more easy to user or prompt friendly
Projects
None yet
2 participants