Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: Improve DataFusionError documentation #8792

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jan 8, 2024

Which issue does this PR close?

Part of #7013

Rationale for this change

Inspired by #8781 I have seen several cases where people are confused about when to use DataFusionError::Internal vs DataFusionError::Plan. etc

What changes are included in this PR?

Update doc comments for DataFusionError, making liberal use of @crepererum 's great description #8781 (comment)

Are these changes tested?

existing coverage

Are there any user-facing changes?

better documentation. No functional changes

@alamb alamb added the documentation Improvements or additions to documentation label Jan 8, 2024
@github-actions github-actions bot removed the documentation Improvements or additions to documentation label Jan 8, 2024
datafusion/common/src/error.rs Outdated Show resolved Hide resolved
datafusion/common/src/error.rs Outdated Show resolved Hide resolved
datafusion/common/src/error.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@crepererum crepererum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@alamb alamb merged commit 40e4c60 into apache:main Jan 9, 2024
22 checks passed
@alamb alamb deleted the alamb/error_docs branch January 9, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants