Standardize CompressionTypeVariant encoding in protobuf
#8785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahgao
reviewed
Jan 8, 2024
| @@ -212,7 +212,7 @@ message CreateExternalTableNode { | |||
| bool if_not_exists = 7; | |||
| string delimiter = 8; | |||
| string definition = 9; | |||
| string file_compression_type = 10; | |||
| CompressionTypeVariant file_compression_type = 10; | |||
There was a problem hiding this comment.
I think we should avoid reusing tag numbers.
The reasons can be referenced here.
I prefer to make changes like the following.
reserved 10; // was string file_compression_type
CompressionTypeVariant file_compression_type = 17;There was a problem hiding this comment.
I was not aware of this, thanks @jonahgao for the advice.
7 tasks
alamb
changed the title
CompressionTypeVariant encoding in protobuf
Thanks so much Andrew for the commits, I was supposed to submit the code yesterday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #8680.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?