Introduce return type for aggregate sum #8141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jayzhan211 <[email protected]>
Signed-off-by: jayzhan211 <[email protected]>
Signed-off-by: jayzhan211 <[email protected]>
Signed-off-by: jayzhan211 <[email protected]>
waynexia
approved these changes
Nov 13, 2023
| @@ -53,11 +56,12 @@ impl Sum { | |||
| name: impl Into<String>, | |||
| data_type: DataType, | |||
| ) -> Self { | |||
| let data_type = sum_return_type(&data_type).unwrap(); | |||
| let return_type = sum_return_type(&data_type).unwrap(); | |||
There was a problem hiding this comment.
sun_return_type doesn't cover the List type for now
|
Thank you @jayzhan211 and @waynexia |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #7960
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?