Minor: Add tests for binary / utf8 coercion #7839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I got too carried away. The fixes will be different |
tustvold
approved these changes
Oct 17, 2023
|
Since this PR is only tests and I have another PR I want to build on this, merging now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related to
Rationale for this change
While working on Clickbench results as part of the #6782 I hit #7342 and I didn't know how many other issues @JayjeetAtGithub hit that are still an issue.
What changes are included in this PR?
Add tests for the above issues (and it turns out that #7343 is no longer an issue)
Are these changes tested?
This is only tests
Are there any user-facing changes?