Minor: improve error message for interval subtraction #6230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
alamb
commented
May 4, 2023
| @@ -1031,7 +1031,7 @@ SELECT '2000-01-01T00:00:00'::timestamp - '2010-01-01T00:00:00'::timestamp; | |||
| 0 years 0 mons -3653 days 0 hours 0 mins 0.000000000 secs | |||
|
|
|||
| # Interval - Timestamp => error | |||
| statement error DataFusion error: Error during planning: interval can't subtract timestamp/date | |||
| statement error DataFusion error: Error during planning: Invalid interval subtraction: Interval\(MonthDayNano\) \- Timestamp\(Nanosecond, None\) | |||
There was a problem hiding this comment.
I would like to hear opinions on this new message. I think it is better but still not great as it has references to the detailed Arrow types.
There was a problem hiding this comment.
I agree it is better than status quo.
alamb
changed the title
alamb
force-pushed
the
alamb/better_error_message
branch
from
1b3a4cf to
f32bc1e
Compare
crepererum
approved these changes
May 5, 2023
|
Given this logic was refactored substantially, I think I am going to punt on any possible improvements now so closing this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft as it builds on #6201Which issue does this PR close?
Follow on from #6201
Rationale for this change
@crepererum noticed that the error messages could be improved when trying to subtract things from intervals -- see https://github.com/apache/arrow-datafusion/pull/6201/files#r1183584830
What changes are included in this PR?
Improve error message
Are these changes tested?
yes
Are there any user-facing changes?