Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use parquet file offset for file range pruning #5997

Merged
merged 5 commits into from
Apr 13, 2023
Merged

Don't use parquet file offset for file range pruning #5997

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5fdde54
Don't use parquet file offset for file range pruning
tustvold Apr 13, 2023
f5df27d
Update datafusion/core/src/physical_plan/file_format/parquet/row_grou…
tustvold Apr 13, 2023
b6ced94
Format
tustvold Apr 13, 2023
18b81ea
Tweak logic
tustvold Apr 13, 2023
13082c9
Update test
tustvold Apr 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion datafusion/core/src/physical_plan/file_format/parquet/row_groups.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,11 @@ pub(crate) fn prune_row_groups(
let mut filtered = Vec::with_capacity(groups.len());
for (idx, metadata) in groups.iter().enumerate() {
if let Some(range) = &range {
let offset = metadata.column(0).file_offset();
let col = metadata.column(0);
tustvold marked this conversation as resolved.
Show resolved Hide resolved
tustvold marked this conversation as resolved.
Show resolved Hide resolved
let offset = col
.dictionary_page_offset()
.unwrap_or(0)
.max(col.data_page_offset());
if offset < range.start || offset >= range.end {
continue;
}
Expand Down