-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #5500 - Add a Github Actions workflow that builds the docs #5631
Conversation
Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
CC @kou @andygrove |
@@ -1,7 +1,4 @@ | |||
|
|||
<a class="navbar-brand" href="{{ pathto(master_doc) }}"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Converted the PR to a Draft one because of this change.
See #5500 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andygrove or @houqp do you remember what this is used for or if it is critical to fix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I personally think that as long as this removal doesn't render the docs inoperable, it would be fine to remove this code to get the docs publishing and fix it afterwards)
How about using If we use See also:
|
We used |
It is easy for me to make the change if the team prefers this way!
…On Sat, Mar 18, 2023, 00:22 Sutou Kouhei ***@***.***> wrote:
We used publish.subdir for arrow-datafusion-python too.
—
Reply to this email directly, view it on GitHub
<#5631 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABYUQVQE4W4BYIP67IQVMLW4TP2BANCNFSM6AAAAAAV6TBM2A>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
@alamb (or anyone else with permissions) Please create a branch for the site, e.g. |
0d283d2
to
e1c2a2d
Compare
Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
@martin-g @alamb I've created the orphan |
Which issue does this PR close?
Closes #5500
Rationale for this change
Deploy the Datafusion website whenever a change is made in the
docs/
folder.What changes are included in this PR?
A new Github Action is introduced that builds the docs and copies them to arrow-site/datafusion
Are these changes tested?
Yes, I have tested them in my fork.
The only part that is not really tested is the
git push
to arrow-site. But arrow-datafusion-python uses the same codeAre there any user-facing changes?
No