Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #5500 - Add a Github Actions workflow that builds the docs #5631

Closed
wants to merge 5 commits into from

Conversation

martin-g
Copy link
Member

Which issue does this PR close?

Closes #5500

Rationale for this change

Deploy the Datafusion website whenever a change is made in the docs/ folder.

What changes are included in this PR?

A new Github Action is introduced that builds the docs and copies them to arrow-site/datafusion

Are these changes tested?

Yes, I have tested them in my fork.
The only part that is not really tested is the git push to arrow-site. But arrow-datafusion-python uses the same code

Are there any user-facing changes?

No

@martin-g
Copy link
Member Author

CC @kou @andygrove

@martin-g martin-g marked this pull request as draft March 17, 2023 14:21
@@ -1,7 +1,4 @@

<a class="navbar-brand" href="{{ pathto(master_doc) }}">
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Converted the PR to a Draft one because of this change.
See #5500 (comment)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andygrove or @houqp do you remember what this is used for or if it is critical to fix?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I personally think that as long as this removal doesn't render the docs inoperable, it would be fine to remove this code to get the docs publishing and fix it afterwards)

@kou
Copy link
Member

kou commented Mar 17, 2023

How about using publish.subdir in .asf.yaml like ADBC instead of pushing to apache/arrow-site?

https://cwiki.apache.org/confluence/display/INFRA/Git+-+.asf.yaml+features#Git.asf.yamlfeatures-Specifyingasub-directorytopublishto

If we use publish.subdir, we can publish the DataFusion docs to https://arrow.apache.org/datafusion/ by pushing to the asf-site branch in apache/arrow-datafusion (not apache/arrow-site).

See also:

@kou
Copy link
Member

kou commented Mar 17, 2023

We used publish.subdir for arrow-datafusion-python too.

@martin-g
Copy link
Member Author

martin-g commented Mar 18, 2023 via email

@alamb
Copy link
Contributor

alamb commented Mar 18, 2023

It is easy for me to make the change if the team prefers this way!

I think this would be a great idea. Thank you @martin-g and @kou -- getting the docs building regularly is so exciting!

@martin-g
Copy link
Member Author

@alamb (or anyone else with permissions) Please create a branch for the site, e.g. asf-site in arrow-datafusion repo.
You could remove all files and folders in it. Or leave that to the Github Action workflow. It will remove all old content before copying the newly generated HTMLs, as in arrow-datafusion-python

@github-actions github-actions bot added the development-process Related to development process of DataFusion label Mar 21, 2023
@martin-g martin-g force-pushed the issue-5500-asf.yaml-docs branch 3 times, most recently from 0d283d2 to e1c2a2d Compare March 21, 2023 13:07
@github-actions github-actions bot removed the development-process Related to development process of DataFusion label Mar 21, 2023
martin-g and others added 4 commits March 21, 2023 15:08
@martin-g martin-g closed this Mar 21, 2023
@github-actions github-actions bot added the development-process Related to development process of DataFusion label Mar 21, 2023
@kou
Copy link
Member

kou commented Mar 21, 2023

@martin-g @alamb I've created the orphan asf-site branch: https://github.com/apache/arrow-datafusion/tree/asf-site

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development-process Related to development process of DataFusion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automate build and publish of the user guide
3 participants