-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sqlparser to 29.0.0
#4770
Conversation
FYI @Jefffrey and @tustvold and @waitingkuo who I think added things to sqlparser-rs in the latest release @Jefffrey do you have time to update datafusion to parse cube/grouping sets (likely needed due to apache/datafusion-sqlparser-rs#771) ? Here is the failure: cargo test -p datafusion --test sql_integration
failures:
---- sql::aggregates::count_aggregated_cube stdout ----
Error: NotImplemented("Unsupported ast node in sqltorel: Cube([[Identifier(Ident { value: \"c1\", quote_style: None })], [Identifier(Ident { value: \"c2\", quote_style: None })]])")
failures:
sql::aggregates::count_aggregated_cube
test result: FAILED. 551 passed; 1 failed; 8 ignored; 0 measured; 0 filtered out; finished in 37.47s
error: test failed, to rerun pass `-p datafusion --test sql_integration` |
Grouping sets planner
Thank you @Jefffrey ❤️ |
🤔 https://github.com/apache/arrow-datafusion/actions/runs/3812004377/jobs/6484978586
Looks like #4065 -- will check it out later |
I have a fix for the stack overflow here: #4779 I have an idea how to work around it in this pr 🏃 |
Benchmark runs are scheduled for baseline = acb8846 and contender = 9a8190a. 9a8190a is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #2469
Rationale for this change
Keep up with dependencies
What changes are included in this PR?
Are these changes tested?
covered by existing tests
Are there any user-facing changes?
No