Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sqlparser to 29.0.0 #4770

Merged
merged 10 commits into from
Jan 1, 2023
Merged

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Dec 29, 2022

Which issue does this PR close?

Closes #2469

Rationale for this change

Keep up with dependencies

What changes are included in this PR?

  1. Update to sqlparser 29.0.0
  2. Update code for changes in APIs

Are these changes tested?

covered by existing tests

Are there any user-facing changes?

No

@github-actions github-actions bot added core Core DataFusion crate logical-expr Logical plan and expressions sql SQL Planner labels Dec 29, 2022
@alamb
Copy link
Contributor Author

alamb commented Dec 29, 2022

FYI @Jefffrey and @tustvold and @waitingkuo who I think added things to sqlparser-rs in the latest release

@Jefffrey do you have time to update datafusion to parse cube/grouping sets (likely needed due to apache/datafusion-sqlparser-rs#771) ?

Here is the failure:

cargo test -p datafusion --test sql_integration

failures:

---- sql::aggregates::count_aggregated_cube stdout ----
Error: NotImplemented("Unsupported ast node in sqltorel: Cube([[Identifier(Ident { value: \"c1\", quote_style: None })], [Identifier(Ident { value: \"c2\", quote_style: None })]])")


failures:
    sql::aggregates::count_aggregated_cube

test result: FAILED. 551 passed; 1 failed; 8 ignored; 0 measured; 0 filtered out; finished in 37.47s

error: test failed, to rerun pass `-p datafusion --test sql_integration`

@Jefffrey
Copy link
Contributor

I've made PR into your branch: alamb#6

For the grouping sets changes

@alamb

@alamb
Copy link
Contributor Author

alamb commented Dec 31, 2022

Thank you @Jefffrey ❤️

@alamb alamb marked this pull request as ready for review December 31, 2022 12:15
@alamb
Copy link
Contributor Author

alamb commented Dec 31, 2022

🤔 https://github.com/apache/arrow-datafusion/actions/runs/3812004377/jobs/6484978586

thread 'tpcds_logical_q41' has overflowed its stack
error: test failed, to rerun pass `-p datafusion --test tpcds_planning`

Caused by:
  process didn't exit successfully: `D:\a\arrow-datafusion\arrow-datafusion\target\debug\deps\tpcds_planning-89b1905225e9ab66.exe` (exit code: 0xc00000fd, STATUS_STACK_OVERFLOW)
Error: Process completed with exit code 127.

Looks like #4065 -- will check it out later

@Jefffrey
Copy link
Contributor

I raised an issue for that q41 specifically #4728

But can close if deemed duplicate of #4065

@alamb

@alamb
Copy link
Contributor Author

alamb commented Dec 31, 2022

I have a fix for the stack overflow here: #4779

I have an idea how to work around it in this pr 🏃

@alamb
Copy link
Contributor Author

alamb commented Jan 1, 2023

Crazily enough aa0c85a was enough to fix the overflow for this PR. I am working on a more comprehensive fix in #4065

@alamb alamb merged commit 9a8190a into apache:master Jan 1, 2023
@alamb alamb deleted the alamb/update_sqlparser2 branch January 1, 2023 12:31
@ursabot
Copy link

ursabot commented Jan 1, 2023

Benchmark runs are scheduled for baseline = acb8846 and contender = 9a8190a. 9a8190a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate logical-expr Logical plan and expressions sql SQL Planner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for GROUPING SETS syntax in SQL planner
3 participants