fix: serialize user-defined window functions to proto #13421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
physical-expr
jcsherin
commented
Nov 14, 2024
Comment on lines
+2123
to
+2129
| fn try_decode_udwf(&self, name: &str, _buf: &[u8]) -> Result<Arc<WindowUDF>> { | ||
| not_impl_err!("PhysicalExtensionCodec is not provided for window function {name}") | ||
| } | ||
|
|
||
| fn try_encode_udwf(&self, _node: &WindowUDF, _buf: &mut Vec<u8>) -> Result<()> { | ||
| Ok(()) | ||
| } |
There was a problem hiding this comment.
Tested by roundtrip_physical_plan::roundtrip_udwf_extension_codec.
jcsherin
commented
Nov 14, 2024
| WindowFrameBound::CurrentRow, | ||
| ); | ||
|
|
||
| let nth_value_window = |
There was a problem hiding this comment.
This is the test referred in #13201 (comment)
|
Thanks! I can confirm this fixes our tests. |
alamb
approved these changes
Nov 14, 2024
| @@ -120,6 +120,25 @@ pub fn serialize_physical_window_expr( | |||
| window_frame, | |||
| codec, | |||
| )? | |||
| } else if let Some(built_in_window_expr) = expr.downcast_ref::<BuiltInWindowExpr>() { | |||
There was a problem hiding this comment.
The naming of these structures is wild (the physical exprs aren't actually BuiltInWindowExprs) but that is an issue to fix for another day
|
I just merged up from main to fix conflict. |
|
Thanks again @jcsherin |
mwylde
pushed a commit
to ArroyoSystems/arrow-datafusion
that referenced
this pull request
Nov 22, 2024
* Adds roundtrip physical plan test * Adds enum for udwf to `WindowFunction` * initial fix for serializing udwf * Revives deleted test * Adds codec methods for physical plan * Rewrite error message * Minor: rename binding + formatting fixes * Extends `PhysicalExtensionCodec` for udwf * Minor: formatting * Restricts visibility to tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #13401.
Rationale for this change
Same as #13401.
What changes are included in this PR?
PhysicalExtensionCodec:Are these changes tested?
Yes, roundtrip physical plan for,
PhysicalExtensionCodec.Are there any user-facing changes?
No.