Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove window_functions_new docs #13395

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

jonathanc-n
Copy link
Contributor

@jonathanc-n jonathanc-n commented Nov 13, 2024

@github-actions github-actions bot added documentation Improvements or additions to documentation development-process Related to development process of DataFusion labels Nov 13, 2024
@jonathanc-n
Copy link
Contributor Author

For the future, should we be adding sql examples for the window functions?

@alamb
Copy link
Contributor

alamb commented Nov 13, 2024

For the future, should we be adding sql examples for the window functions?

Yes that would be awesome -- any chance you could file a ticket to track doing so? In case it helps, here is a PR with an example of how to do: #13390

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outstanding -- thank you @jonathanc-n

FYI @Omega359 -- the project is finally done!

@comphead comphead merged commit 8a88fdc into apache:main Nov 13, 2024
27 checks passed
@Omega359
Copy link
Contributor

WOOT! I'm glad we were able to get this functionality into DF - I think it'll be better for it!

@alamb
Copy link
Contributor

alamb commented Nov 14, 2024

WOOT! I'm glad we were able to get this functionality into DF - I think it'll be better for it!

100% -- it was also really cool to see so many people involved. Talk about a community effort!

@jonathanc-n jonathanc-n deleted the update-window-functions-docs branch November 27, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development-process Related to development process of DataFusion documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove old static Window Functions page [EPIC] Automatically generate all function documentation from code
4 participants