Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report file location and offset when CSV schema mismatch #13185

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Report file location and offset when CSV schema mismatch #13185

merged 1 commit into from
Oct 30, 2024

Conversation

findepi
Copy link
Member

@findepi findepi commented Oct 30, 2024

No description provided.

@github-actions github-actions bot added the core Core DataFusion crate label Oct 30, 2024
@findepi findepi force-pushed the findepi/report-file-location-and-offset-when-csv-schema-mismatch-6c0997 branch from 8c5dea7 to 96ff23f Compare October 30, 2024 16:01
@findepi
Copy link
Member Author

findepi commented Oct 30, 2024

If apache/arrow-rs#6653 gets accepted, we should get line number errors in all cases where this can be determined.

@findepi
Copy link
Member Author

findepi commented Oct 30, 2024

Example error (with apache/arrow-rs#6653 change):

Datafusion error: Error when processing CSV file tpcds/call_center.csv
caused by
Arrow error: Csv error: Encountered unequal lengths between records on CSV file. Expected 2 records, found 1 records at line 2

alamb
alamb approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a very nice improvement to me - thanks @findepi

@alamb alamb merged commit 4975829 into apache:main Oct 30, 2024
24 checks passed
@findepi findepi deleted the findepi/report-file-location-and-offset-when-csv-schema-mismatch-6c0997 branch October 31, 2024 08:53
@alamb alamb mentioned this pull request Nov 5, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
core Core DataFusion crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@findepi @alamb