Fix: panics in approx_percentile_cont() aggregate function
#11934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
changed the title
approx_percentile_cont() aggregate functionapprox_percentile_cont() aggregate function
alamb
approved these changes
Aug 11, 2024
Dandandan
approved these changes
Aug 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #11871.
Closes #11870.
Closes #11869.
Rationale for this change
There are several crashed bugs in
approx_median()/approx_percentile_cont()/approx_percentile_cont_with_weight()Those functions all rely on
ApproxPercentileAccumulatorfor implementation.This PR includes an edge case fix within
ApproxPercnetileAccumulator, and more details can be found in the comments.What changes are included in this PR?
Are these changes tested?
sqllogictests, note 3 added test cases are equivalent to the ones reported in issues, but they are further reduced.
Are there any user-facing changes?