-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use StringView
by default when reading from parquet
#11723
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
Improvements or additions to documentation
sqllogictest
SQL Logic Tests (.slt)
labels
Jul 30, 2024
alamb
force-pushed
the
alamb/string_view_default
branch
from
July 31, 2024 19:09
411cc3a
to
e7f8cd7
Compare
This was referenced Jul 31, 2024
alamb
commented
Jul 31, 2024
@@ -901,6 +921,29 @@ macro_rules! get_data_page_statistics { | |||
} | |||
Ok(Arc::new(builder.finish())) | |||
}, | |||
// TODO file upstream in Arrowrs -- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I filed upstream as apache/arrow-rs#6164
Suggested change
// TODO file upstream in Arrowrs -- | |
// https://github.com/apache/arrow-rs/issues/6164 |
superceded by #11862 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
core
Core DataFusion crate
documentation
Improvements or additions to documentation
sqllogictest
SQL Logic Tests (.slt)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft until:
StringView
in DataFusion #10918 and file remaining follow on work for StringViewWhich issue does this PR close?
Closes #11682
Rationale for this change
@XiangpengHao @a10y @PsiACE @Weijun-H and others have been working this summer of using
StringView
: #10918 to improve performance,.It is currently disabled behind a config setting. Let's turn it on and improve query performance against parquet files
What changes are included in this PR?
datafusion.execution.parquet.schema_force_string_view
to true by defaultAre these changes tested?
Yes by CI
Benchmark results: Several ClickBench queries get 10-40% faster
Are there any user-facing changes?
Yes. With this change, it means that all strings will be read from parquet files as
StringView
by default.This should result in a significant performance improvement for queries that involve string columns, especially for highly selective ones
It can still be disabled by default if needed
Bug notes
(The idea is I will work through these errors and file tickets)
Cast error
Panic about statistics (that extracting parquet statistics as StringView is not implemented):
Clickbench exteded: