Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ArragAgg (not ordered or distinct) into a UDAF #11045

Closed
wants to merge 6 commits into from
Closed

Make ArragAgg (not ordered or distinct) into a UDAF #11045

wants to merge 6 commits into from

Commits on Jun 22, 2024

  1. Add input_nullable to UDAF args StateField/AccumulatorArgs 

    This follows how it done for input_type and only provide a single value.
But might need to be changed into a Vec in the future.

This is need when we are moving `arrag_agg` to udaf where one of the
states nullability will depend on the nullability of the input.
    @eejbyfeldt
    eejbyfeldt committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    2e4b5b0 View commit details
    Browse the repository at this point in the history

  2. Make ArragAgg (not ordered or distinct) into a UDAF

    @eejbyfeldt
    eejbyfeldt committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    ecdf274 View commit details
    Browse the repository at this point in the history

  3. Add roundtrip_expr_api test case

    @eejbyfeldt
    eejbyfeldt committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    8ec6100 View commit details
    Browse the repository at this point in the history

  4. Address PR comments

    @eejbyfeldt
    eejbyfeldt committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    47ab253 View commit details
    Browse the repository at this point in the history

  5. Propegate input nullability for aggregates

    @eejbyfeldt
    eejbyfeldt committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    1a69045 View commit details
    Browse the repository at this point in the history

  6. Remove from accumulator args

    @eejbyfeldt
    eejbyfeldt committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    a6ea404 View commit details
    Browse the repository at this point in the history