From c337448663783b52b484f67a6a363af15e8f27f5 Mon Sep 17 00:00:00 2001 From: Jacob Sherin Date: Wed, 19 Jun 2024 20:42:35 +0530 Subject: [PATCH 1/3] bumps `protoc` minimum version from 3.12 -> 3.15 --- docs/source/contributor-guide/getting_started.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/source/contributor-guide/getting_started.md b/docs/source/contributor-guide/getting_started.md index 64d5a0d43d5d..30adb3500417 100644 --- a/docs/source/contributor-guide/getting_started.md +++ b/docs/source/contributor-guide/getting_started.md @@ -50,11 +50,11 @@ $ pacman -S protobuf $ brew install protobuf ``` -You will want to verify the version installed is `3.12` or greater, which introduced support for explicit [field presence](https://github.com/protocolbuffers/protobuf/blob/v3.12.0/docs/field_presence.md). Older versions may fail to compile. +You will want to verify the version installed is `3.15` or greater, which introduced support for explicit [field presence](https://github.com/protocolbuffers/protobuf/blob/v3.15.0/docs/field_presence.md). Older versions may fail to compile. ```shell $ protoc --version -libprotoc 3.12.4 +libprotoc 3.15.0 ``` Alternatively a binary release can be downloaded from the [Release Page](https://github.com/protocolbuffers/protobuf/releases) or [built from source](https://github.com/protocolbuffers/protobuf/blob/main/src/README.md). From 9fdef23146edb604588408eaafda3a9d6eaf2f27 Mon Sep 17 00:00:00 2001 From: Jacob Sherin Date: Mon, 17 Jun 2024 23:34:18 +0530 Subject: [PATCH 2/3] Minor: Fix link for Protoc installation --- datafusion/proto/CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/datafusion/proto/CONTRIBUTING.md b/datafusion/proto/CONTRIBUTING.md index f124c233d04f..db3658c72610 100644 --- a/datafusion/proto/CONTRIBUTING.md +++ b/datafusion/proto/CONTRIBUTING.md @@ -29,4 +29,4 @@ valid installation of [protoc] (see [installation instructions] for details). ``` [protoc]: https://github.com/protocolbuffers/protobuf#protocol-compiler-installation -[installation instructions]: https://datafusion.apache.org/contributor-guide/#protoc-installation +[installation instructions]: https://datafusion.apache.org/contributor-guide/getting_started.html#protoc-installation From 0a57e6714fbc83f12cd4cc64f0ad6cd0310b6c89 Mon Sep 17 00:00:00 2001 From: Jacob Sherin Date: Wed, 19 Jun 2024 22:44:41 +0530 Subject: [PATCH 3/3] minor: removes reference to 3.12 --- docs/source/contributor-guide/getting_started.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/source/contributor-guide/getting_started.md b/docs/source/contributor-guide/getting_started.md index 30adb3500417..696d6d3a0fe2 100644 --- a/docs/source/contributor-guide/getting_started.md +++ b/docs/source/contributor-guide/getting_started.md @@ -50,7 +50,7 @@ $ pacman -S protobuf $ brew install protobuf ``` -You will want to verify the version installed is `3.15` or greater, which introduced support for explicit [field presence](https://github.com/protocolbuffers/protobuf/blob/v3.15.0/docs/field_presence.md). Older versions may fail to compile. +You will want to verify the version installed is `3.15` or greater, which has support for explicit [field presence](https://github.com/protocolbuffers/protobuf/blob/v3.15.0/docs/field_presence.md). Older versions may fail to compile. ```shell $ protoc --version