Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: Remove prefer_hash_join env variable for clickbench #10933

Merged
merged 1 commit into from
Jun 16, 2024

Conversation

jayzhan211
Copy link
Contributor

Which issue does this PR close?

Closes #.

Rationale for this change

clickbench does not expect --prefer_hash_join, remove it. It is introduce in #10809

***************************
DataFusion Benchmark Script
COMMAND: run
BENCHMARK: clickbench_partitioned
DATAFUSION_DIR: /Users/bytedance/arrow-datafusion/benchmarks/..
BRANCH_NAME: rm-hash-join-env-clickbench
DATA_DIR: /Users/bytedance/arrow-datafusion/benchmarks/data
RESULTS_DIR: /Users/bytedance/arrow-datafusion/benchmarks/results/rm-hash-join-env-clickbench
CARGO_COMMAND: cargo run --profile release-nonlto
PREFER_HASH_JOIN: true
***************************
RESULTS_FILE: /Users/bytedance/arrow-datafusion/benchmarks/results/rm-hash-join-env-clickbench/clickbench_partitioned.json
Running clickbench (partitioned, 100 files) benchmark...
    Finished `release-nonlto` profile [optimized] target(s) in 0.68s
     Running `/Users/bytedance/arrow-datafusion/target/release-nonlto/dfbench clickbench --iterations 5 --path /Users/bytedance/arrow-datafusion/benchmarks/data/hits_partitioned --prefer_hash_join true --queries-path /Users/bytedance/arrow-datafusion/benchmarks/queries/clickbench/queries.sql -o /Users/bytedance/arrow-datafusion/benchmarks/results/rm-hash-join-env-clickbench/clickbench_partitioned.json`
error: Found argument '--prefer_hash_join' which wasn't expected, or isn't valid in this context

USAGE:
    dfbench clickbench --iterations <iterations> --path <path>

For more information try --help

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Signed-off-by: jayzhan211 <[email protected]>
@jayzhan211 jayzhan211 changed the title Remove prefer_hash_join env variable for clickbench Minor: Remove prefer_hash_join env variable for clickbench Jun 16, 2024
@jayzhan211 jayzhan211 marked this pull request as ready for review June 16, 2024 08:39
@jayzhan211 jayzhan211 requested a review from comphead June 16, 2024 08:39
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jayzhan211

Another alternative would be to add the flag to the clickbench binary. However,
since the clickbench queries do not have joins I think this is the best approach

cc @comphead

@alamb alamb merged commit d175163 into apache:main Jun 16, 2024
23 of 24 checks passed
@jayzhan211 jayzhan211 deleted the rm-hash-join-env-clickbench branch June 16, 2024 11:56
findepi pushed a commit to findepi/datafusion that referenced this pull request Jul 16, 2024
Signed-off-by: jayzhan211 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants