Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: move stddev test to slt #10741

Merged
merged 1 commit into from
May 31, 2024
Merged

Minor: move stddev test to slt #10741

merged 1 commit into from
May 31, 2024

Conversation

marvinlanhenke
Copy link
Contributor

Which issue does this PR close?

Partly #10384

Rationale for this change

What changes are included in this PR?

  • moved tests to aggregate.slt
  • left UT for merge still inside stddev.rs since those test the Accumulator

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added physical-expr Physical Expressions sqllogictest SQL Logic Tests (.slt) labels May 31, 2024
@marvinlanhenke
Copy link
Contributor Author

@jayzhan211 PTAL. I'm not sure about the UTs for merge - for now I left them untouched.

Copy link
Contributor

@jayzhan211 jayzhan211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

I'm not sure what kind of query can trigger merge_batch too

@alamb alamb merged commit a803214 into apache:main May 31, 2024
23 checks passed
findepi pushed a commit to findepi/datafusion that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
physical-expr Physical Expressions sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants