Fix SortMergeJoin with join filter filtering all rows out #10495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
May 14, 2024
datafusion/core/tests/sql/joins.rs
Outdated
| let sql = "set datafusion.execution.batch_size = 1"; | ||
| let _ = ctx.sql(sql).await?.collect().await?; | ||
|
|
||
| let sql = " |
There was a problem hiding this comment.
is there any reason this isn't a slt test (in https://github.com/apache/datafusion/blob/main/datafusion/sqllogictest/test_files/sort_merge_join.slt)? Looks like it would work just fine
There was a problem hiding this comment.
No, I simply copy the reproducer from the issue. Let me move it to sort_merge_join.slt.
comphead
approved these changes
May 14, 2024
| @@ -1323,7 +1323,9 @@ impl SMJStream { | |||
| // If join filter exists, `self.output_size` is not accurate as we don't know the exact | |||
| // number of rows in the output record batch. If streamed row joined with buffered rows, | |||
| // once join filter is applied, the number of output rows may be more than 1. | |||
| if record_batch.num_rows() > self.output_size { | |||
| // If `record_batch` is empty, we should reset `self.output_size` to 0. It could be happened | |||
github-actions
bot
added
sqllogictest
comphead
reviewed
May 14, 2024
10 tasks
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
* Fix SortMergeJoin with join filter filtering all rows out * Move test * Update datafusion/sqllogictest/test_files/sort_merge_join.slt --------- Co-authored-by: Oleks V <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #10491.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?