Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: Add more docs and examples for Expr::unalias #10406

Merged
merged 1 commit into from
May 7, 2024

Conversation

alamb
Copy link
Contributor

@alamb alamb commented May 7, 2024

Which issue does this PR close?

Part of #7013

Rationale for this change

I have had to look up the behavior of this function several times when working on optimizer rules, so I would like to better document it

What changes are included in this PR?

  1. add doc comments + examples

Are these changes tested?

Doc CI check

Are there any user-facing changes?

Better docs

Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @alamb

@alamb
Copy link
Contributor Author

alamb commented May 7, 2024

Thanks for the speedy review @comphead

@alamb alamb merged commit 5cc66f2 into apache:main May 7, 2024
23 checks passed
findepi pushed a commit to findepi/datafusion that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
logical-expr Logical plan and expressions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants