Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Coalesce casting logic to follows what Postgres and DuckDB do. Introduce signature that do non-comparison coercion #10268

Merged
merged 43 commits into from
May 26, 2024
Merged

Fix Coalesce casting logic to follows what Postgres and DuckDB do. Introduce signature that do non-comparison coercion #10268

merged 43 commits into from
May 26, 2024

Commits on Apr 27, 2024

  1. remove casting for coalesce 

    Signed-off-by: jayzhan211 <[email protected]>
    @jayzhan211
    jayzhan211 committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    c79156f View commit details
    Browse the repository at this point in the history

  2. add more test 

    Signed-off-by: jayzhan211 <[email protected]>
    @jayzhan211
    jayzhan211 committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    a36e6b2 View commit details
    Browse the repository at this point in the history

  3. add more test 

    Signed-off-by: jayzhan211 <[email protected]>
    @jayzhan211
    jayzhan211 committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    bf16c92 View commit details
    Browse the repository at this point in the history

  4. crate only visibility 

    Signed-off-by: jayzhan211 <[email protected]>
    @jayzhan211
    jayzhan211 committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    407e3c7 View commit details
    Browse the repository at this point in the history

  5. polish comment 

    Signed-off-by: jayzhan211 <[email protected]>
    @jayzhan211
    jayzhan211 committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    03b9162 View commit details
    Browse the repository at this point in the history

  6. improve test 

    Signed-off-by: jayzhan211 <[email protected]>
    @jayzhan211
    jayzhan211 committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    4abf29d View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2024

  1. backup 

    Signed-off-by: jayzhan211 <[email protected]>
    @jayzhan211
    jayzhan211 committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    4965e8d View commit details
    Browse the repository at this point in the history

  2. introduce new signautre for coalesce 

    Signed-off-by: jayzhan211 <[email protected]>
    @jayzhan211
    jayzhan211 committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    81f0235 View commit details
    Browse the repository at this point in the history

  3. cleanup 

    Signed-off-by: jayzhan211 <[email protected]>
    @jayzhan211
    jayzhan211 committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    bae996c View commit details
    Browse the repository at this point in the history

  4. cleanup 

    Signed-off-by: jayzhan211 <[email protected]>
    @jayzhan211
    jayzhan211 committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    ddf9b1c View commit details
    Browse the repository at this point in the history

  5. ignore err msg 

    Signed-off-by: jayzhan211 <[email protected]>
    @jayzhan211
    jayzhan211 committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    c2799ea View commit details
    Browse the repository at this point in the history

  6. fmt 

    Signed-off-by: jayzhan211 <[email protected]>
    @jayzhan211
    jayzhan211 committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    2574896 View commit details
    Browse the repository at this point in the history

  7. fix doc 

    Signed-off-by: jayzhan211 <[email protected]>
    @jayzhan211
    jayzhan211 committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    6a17e57 View commit details
    Browse the repository at this point in the history

  8. cleanup 

    Signed-off-by: jayzhan211 <[email protected]>
    @jayzhan211
    jayzhan211 committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    4cba8c5 View commit details
    Browse the repository at this point in the history

  9. add more test 

    Signed-off-by: jayzhan211 <[email protected]>
    @jayzhan211
    jayzhan211 committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    f1cfb8d View commit details
    Browse the repository at this point in the history

  10. switch to type_resolution coercion 

    Signed-off-by: jayzhan211 <[email protected]>
    @jayzhan211
    jayzhan211 committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    d2e83d3 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. Merge remote-tracking branch 'upstream/main' into fix-coelesce

    @jayzhan211
    jayzhan211 committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    3a88ad7 View commit details
    Browse the repository at this point in the history

  2. fix i64 and u64 case 

    Signed-off-by: jayzhan211 <[email protected]>
    @jayzhan211
    jayzhan211 committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    03880a3 View commit details
    Browse the repository at this point in the history

  3. add more tests 

    Signed-off-by: jayzhan211 <[email protected]>
    @jayzhan211
    jayzhan211 committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    481f548 View commit details
    Browse the repository at this point in the history

  4. cleanup 

    Signed-off-by: jayzhan211 <[email protected]>
    @jayzhan211
    jayzhan211 committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    dfc4176 View commit details
    Browse the repository at this point in the history

  5. add null case 

    Signed-off-by: jayzhan211 <[email protected]>
    @jayzhan211
    jayzhan211 committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    46a9060 View commit details
    Browse the repository at this point in the history

  6. fmt 

    Signed-off-by: jayzhan211 <[email protected]>
    @jayzhan211
    jayzhan211 committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    d656645 View commit details
    Browse the repository at this point in the history

  7. fix 

    Signed-off-by: jayzhan211 <[email protected]>
    @jayzhan211
    jayzhan211 committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    5683447 View commit details
    Browse the repository at this point in the history

  8. rename to type_union_resolution 

    Signed-off-by: jayzhan211 <[email protected]>
    @jayzhan211
    jayzhan211 committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    b949fae View commit details
    Browse the repository at this point in the history

  9. add comment 

    Signed-off-by: jayzhan211 <[email protected]>
    @jayzhan211
    jayzhan211 committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    5aaeb5b View commit details
    Browse the repository at this point in the history

Commits on May 1, 2024

  1. Merge remote-tracking branch 'upstream/main' into fix-coelesce

    @jayzhan211
    jayzhan211 committed May 1, 2024
    Configuration menu
    Copy the full SHA
    a968c0e View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. Merge remote-tracking branch 'upstream/main' into fix-coelesce

    @jayzhan211
    jayzhan211 committed May 2, 2024
    Configuration menu
    Copy the full SHA
    cf679c5 View commit details
    Browse the repository at this point in the history

  2. cleanup 

    Signed-off-by: jayzhan211 <[email protected]>
    @jayzhan211
    jayzhan211 committed May 2, 2024
    Configuration menu
    Copy the full SHA
    15471ab View commit details
    Browse the repository at this point in the history

  3. fix test 

    Signed-off-by: jayzhan211 <[email protected]>
    @jayzhan211
    jayzhan211 committed May 2, 2024
    Configuration menu
    Copy the full SHA
    e5cc46b View commit details
    Browse the repository at this point in the history

  4. add comment 

    Signed-off-by: jayzhan211 <[email protected]>
    @jayzhan211
    jayzhan211 committed May 2, 2024
    Configuration menu
    Copy the full SHA
    a810e85 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2024

  1. rm test 

    Signed-off-by: jayzhan211 <[email protected]>
    @jayzhan211
    jayzhan211 committed May 3, 2024
    Configuration menu
    Copy the full SHA
    cb16cda View commit details
    Browse the repository at this point in the history

Commits on May 12, 2024

  1. Merge remote-tracking branch 'upstream/main' into fix-coelesce

    @jayzhan211
    jayzhan211 committed May 12, 2024
    Configuration menu
    Copy the full SHA
    53bedda View commit details
    Browse the repository at this point in the history

  2. cleanup since rebase 

    Signed-off-by: jayzhan211 <[email protected]>
    @jayzhan211
    jayzhan211 committed May 12, 2024
    Configuration menu
    Copy the full SHA
    a37da2d View commit details
    Browse the repository at this point in the history

  3. add more test 

    Signed-off-by: jayzhan211 <[email protected]>
    @jayzhan211
    jayzhan211 committed May 12, 2024
    Configuration menu
    Copy the full SHA
    70239e0 View commit details
    Browse the repository at this point in the history

  4. add more test 

    Signed-off-by: jayzhan211 <[email protected]>
    @jayzhan211
    jayzhan211 committed May 12, 2024
    Configuration menu
    Copy the full SHA
    be116f8 View commit details
    Browse the repository at this point in the history

  5. fix msg 

    Signed-off-by: jayzhan211 <[email protected]>
    @jayzhan211
    jayzhan211 committed May 12, 2024
    Configuration menu
    Copy the full SHA
    8f4e991 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. Merge remote-tracking branch 'upstream/main' into fix-coelesce

    @jayzhan211
    jayzhan211 committed May 14, 2024
    Configuration menu
    Copy the full SHA
    6a8fe6f View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into fix-coelesce

    @jayzhan211
    jayzhan211 committed May 14, 2024
    Configuration menu
    Copy the full SHA
    20e618e View commit details
    Browse the repository at this point in the history

  3. fmt 

    Signed-off-by: jayzhan211 <[email protected]>
    @jayzhan211
    jayzhan211 committed May 14, 2024
    Configuration menu
    Copy the full SHA
    4153593 View commit details
    Browse the repository at this point in the history

  4. rm pure_string_coercion 

    Signed-off-by: jayzhan211 <[email protected]>
    @jayzhan211
    jayzhan211 committed May 14, 2024
    Configuration menu
    Copy the full SHA
    030a519 View commit details
    Browse the repository at this point in the history

  5. rm duplicate 

    Signed-off-by: jayzhan211 <[email protected]>
    @jayzhan211
    jayzhan211 committed May 14, 2024
    Configuration menu
    Copy the full SHA
    5b797d5 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2024

  1. change type in select.slt 

    Signed-off-by: jayzhan211 <[email protected]>
    @jayzhan211
    jayzhan211 committed May 25, 2024
    Configuration menu
    Copy the full SHA
    b954479 View commit details
    Browse the repository at this point in the history

  2. fix slt 

    Signed-off-by: jayzhan211 <[email protected]>
    @jayzhan211
    jayzhan211 committed May 25, 2024
    Configuration menu
    Copy the full SHA
    829b5a2 View commit details
    Browse the repository at this point in the history