You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I see -- it seems like the issue is that the accumulator implementation requires PhysicalSortExpr.
To pull the code into its own crate maybe we could pull out the relevant pieces of datafusion-physical-expr into datafusion-physical-core or something (as a follow on PR)
We want to move aggregate function to aggreagate-functions crate but avoid importing whole physical-expr crate. Therefore, we need to move PhysicalSortExpr for ordering, and of course PhysicalExpr to physical-expr-core. Then, we can import it only.
To pull the code into its own crate maybe we could pull out the relevant pieces of
datafusion-physical-expr
intodatafusion-physical-core
or something (as a follow on PR)Originally posted by @alamb in #9874 (comment)
We want to move aggregate function to
aggreagate-functions
crate but avoid importing wholephysical-expr
crate. Therefore, we need to move PhysicalSortExpr for ordering, and of course PhysicalExpr tophysical-expr-core
. Then, we can import it only.part of #8708
The text was updated successfully, but these errors were encountered: