Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move PhysicalExpr and PhysicalSortExpr to physical-expr-core #9921

Closed
jayzhan211 opened this issue Apr 3, 2024 · 1 comment · Fixed by #9926
Closed

Move PhysicalExpr and PhysicalSortExpr to physical-expr-core #9921

jayzhan211 opened this issue Apr 3, 2024 · 1 comment · Fixed by #9926
Assignees

Comments

@jayzhan211
Copy link
Contributor

jayzhan211 commented Apr 3, 2024

          I see -- it seems like the issue is that the accumulator implementation requires PhysicalSortExpr.

To pull the code into its own crate maybe we could pull out the relevant pieces of datafusion-physical-expr into datafusion-physical-core or something (as a follow on PR)

Originally posted by @alamb in #9874 (comment)

We want to move aggregate function to aggreagate-functions crate but avoid importing whole physical-expr crate. Therefore, we need to move PhysicalSortExpr for ordering, and of course PhysicalExpr to physical-expr-core. Then, we can import it only.

part of #8708

@jayzhan211 jayzhan211 self-assigned this Apr 3, 2024
@alamb
Copy link
Contributor

alamb commented Apr 3, 2024

FYI @mustafasrepo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants