Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ExecutionPlan implementations immutable #987

Closed
rdettai opened this issue Sep 10, 2021 · 2 comments
Closed

Make ExecutionPlan implementations immutable #987

rdettai opened this issue Sep 10, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@rdettai
Copy link
Contributor

rdettai commented Sep 10, 2021

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
This is a follow up to #962.

Currently we cannot compute all the statistics at instantiation because some implementations of the ExecutionPlan trait are mutable.

Describe the solution you'd like
The proposition is to make all ExecutionPlan implementations immutable and then transform the statistics method signature to:
fn statistics(&self) -> &Statistics;

Describe alternatives you've considered
Instead of trying to compute the statistics at instantiation, a solution could be to have statistics(&mut self) and cache the result from there. But if the plan is mutable this is error prone because the cached statistics needs to be correctly invalidated when updates occur.

Additional context
#965 (comment)

@rdettai rdettai added the enhancement New feature or request label Sep 10, 2021
@mingmwang
Copy link
Contributor

mingmwang commented Oct 28, 2022

Is it still valid? I think today's ExecutionPlan is already immutable except for the run time plan metrics.

@rdettai
Copy link
Contributor Author

rdettai commented Nov 6, 2022

I think a lot of things have changed since I opened this. Closing it.

@rdettai rdettai closed this as not planned Won't fix, can't repro, duplicate, stale Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants