We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
struct
named_struct
This is a follow on to #9743 where @gstvg added a great named_struct function to construct StructArrays ❤️
StructArrays
As part of that PR, @yyy1000 noted that the existing code in the struct udf is now never called: #9743 (comment)
Make the invoke()` function reutrn a not yet implemented error https://github.com/apache/arrow-datafusion/blob/ce3d446be5f6a11664e100fc47940e6ecb5418d3/datafusion/functions/src/core/struct.rs#L90-L92
Implement the simplify API to rewrite calls to struct() to a call to named_struct
simplify
struct()
https://github.com/apache/arrow-datafusion/blob/ce3d446be5f6a11664e100fc47940e6ecb5418d3/datafusion/expr/src/udf.rs#L372-L378
c0
We could also just remove the struct udf entirely, though in that case it is important to keep the struct expr_fn function for backwards compatibility
https://github.com/apache/arrow-datafusion/blob/ce3d446be5f6a11664e100fc47940e6ecb5418d3/datafusion/functions/src/core/mod.rs#L44
I think it could be implemented as its own function like
No response
The text was updated successfully, but these errors were encountered:
I think this is a good first issue as it is well specified, and there are patterns to follow
Sorry, something went wrong.
This ended up causing issues as the column name is different (e.g. see #9891). I am going to make a quick fix
alamb
Successfully merging a pull request may close this issue.
Is your feature request related to a problem or challenge?
This is a follow on to #9743 where @gstvg added a great
named_struct
function to constructStructArrays
❤️As part of that PR, @yyy1000 noted that the existing code in the
struct
udf is now never called: #9743 (comment)Describe the solution you'd like
Make the invoke()` function reutrn a not yet implemented error https://github.com/apache/arrow-datafusion/blob/ce3d446be5f6a11664e100fc47940e6ecb5418d3/datafusion/functions/src/core/struct.rs#L90-L92
Implement the
simplify
API to rewrite calls tostruct()
to a call tonamed_struct
https://github.com/apache/arrow-datafusion/blob/ce3d446be5f6a11664e100fc47940e6ecb5418d3/datafusion/expr/src/udf.rs#L372-L378
struct
rather than building up thec0
, `c1, etc and calling named_structDescribe alternatives you've considered
We could also just remove the struct udf entirely, though in that case it is important to keep the struct expr_fn function for backwards compatibility
https://github.com/apache/arrow-datafusion/blob/ce3d446be5f6a11664e100fc47940e6ecb5418d3/datafusion/functions/src/core/mod.rs#L44
I think it could be implemented as its own function like
Additional context
No response
The text was updated successfully, but these errors were encountered: