Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a AggregateUDFImpl::simplfy() API #9526

Closed
alamb opened this issue Mar 10, 2024 · 3 comments · Fixed by #10354
Closed

Add a AggregateUDFImpl::simplfy() API #9526

alamb opened this issue Mar 10, 2024 · 3 comments · Fixed by #10354
Labels
enhancement New feature or request

Comments

@alamb
Copy link
Contributor

alamb commented Mar 10, 2024

Is your feature request related to a problem or challenge?

For the same reasons as described for ScalarUDFImpl on #9289 we should allow user defined aggregates to provide simplification rules

Describe the solution you'd like

Add AggregateUDFImpl::simplify, following the model @jayzhan211 made in
#9304

Describe alternatives you've considered

No response

Additional context

No response

@yyy1000
Copy link
Contributor

yyy1000 commented Mar 12, 2024

I want to try it, maybe I can learn from #9304

@alamb
Copy link
Contributor Author

alamb commented Mar 12, 2024

Thanks @yyy1000 -- I think the first thing to do would be to pick an example to deonstrate how it works

Perhaps you could implement a case to simplify COUNT(NULL) to 0 or something?

@yyy1000
Copy link
Contributor

yyy1000 commented Mar 12, 2024

Ok! I will try it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants