Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup regex_expressions.rs to remove _regexp_match function #9106

Closed
Omega359 opened this issue Feb 2, 2024 · 0 comments · Fixed by #9107
Closed

Cleanup regex_expressions.rs to remove _regexp_match function #9106

Omega359 opened this issue Feb 2, 2024 · 0 comments · Fixed by #9107
Labels
enhancement New feature or request

Comments

@Omega359
Copy link
Contributor

Omega359 commented Feb 2, 2024

Is your feature request related to a problem or challenge?

arrow-rs 50 includes this functionality mentioned in a comment in the file:

/// TODO: Remove this once it is included in arrow-rs new release.
/// <https://github.com/apache/arrow-rs/pull/5235>
fn _regexp_match<OffsetSize: OffsetSizeTrait>(

thus this function can be removed and the arrow-rs implementation can be called directly.

As noted in #9102 (comment)

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Additional context

No response
@Omega359 Omega359 added the enhancement New feature or request label Feb 2, 2024
Omega359 added a commit to Omega359/arrow-datafusion that referenced this issue Feb 2, 2024
@Omega359
Cleanup regex_expressions.rs to remove _regexp_match function apache#…
a0b67a2 
…9106
@Omega359 Omega359 mentioned this issue Feb 2, 2024
Merged
@alamb alamb mentioned this issue Feb 2, 2024
Closed
6 tasks
alamb pushed a commit that referenced this issue Feb 3, 2024
@Omega359 @viirya
Cleanup regex_expressions.rs to remove _regexp_match function (#9107)
9d1502b 
* Cleanup regex_expressions.rs to remove _regexp_match function #9106

* Adding datafusion-cli Cargo.lock

* Update datafusion/physical-expr/src/regex_expressions.rs

Removed extraneous line as per code review suggestion

Co-authored-by: Liang-Chi Hsieh <[email protected]>

* Update datafusion/physical-expr/src/regex_expressions.rs

Removed extraneous lines as per code review

Co-authored-by: Liang-Chi Hsieh <[email protected]>

* Make rustfmt happy again.

---------

Co-authored-by: Liang-Chi Hsieh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cleanup regex_expressions.rs to remove _regexp_match function Omega359/arrow-datafusion
1 participant
@Omega359