Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Placeholders cannot be substituted with values when the values type is coercible but not equivalent #8976

Closed
erratic-pattern opened this issue Jan 23, 2024 · 0 comments · Fixed by #8977
Closed

Placeholders cannot be substituted with values when the values type is coercible but not equivalent #8976

erratic-pattern opened this issue Jan 23, 2024 · 0 comments · Fixed by #8977
Labels
bug Something isn't working

Comments

@erratic-pattern
Copy link
Contributor

Describe the bug

Currently when substituting placeholders with LogicalPlan::with_param_values, the types of the ScalarValues used in the ParamValues collection must match exactly with the Expr::Placeholder expression being substituted, even when the ScalarValue can be coerced to the type of the Expr::Placeholder (e.g. UInt64 to Int64). This is a bug caused by an eager check in the ParamValues code. See linked PR for more context.

To Reproduce

No response

Expected behavior

No response

Additional context

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: allow placeholders to be substituted when coercible erratic-pattern/arrow-datafusion
1 participant
@erratic-pattern