Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo cannot install datafusion-cli with version 5 #883

Closed
capacman opened this issue Aug 14, 2021 · 7 comments
Closed

cargo cannot install datafusion-cli with version 5 #883

capacman opened this issue Aug 14, 2021 · 7 comments
Labels
bug Something isn't working

Comments

@capacman
Copy link

Describe the bug
In datafusion 4 i can install datafusion-cli just by installing datafusion via cargo but now when i want to install/update datafusion it says

cargo install datafusion                 
    Updating `http://localhost:8080/index` index
  Downloaded datafusion v5.0.0 (registry `http://localhost:8080/index`)
  Downloaded 1 crate (336.4 KB) in 0.48s
error: there is nothing to install in `datafusion v5.0.0`, because it has no binaries
`cargo install` is only for installing programs, and can't be used with libraries.
To use a library crate, add it as a dependency in a Cargo project instead

To Reproduce
just issue command
cargo install datafusion

Expected behavior
Install datafusion-cli with command cargo install datafusion

@capacman capacman added the bug Something isn't working label Aug 14, 2021
@houqp
Copy link
Member

houqp commented Aug 14, 2021

datafusion-cli has been moved into its own crate in 5.0.0 release, but we haven't released a new version of the cli yet with the 5.0.0 release.

@andygrove @alamb we don't have datafusion-cli name reserved in crates.io, do we want to publish it to crates.io? Or do you expect us to only release binaries for the cli going forword?

@andygrove
Copy link
Member

I think we should be publishing the crate. We cannot release from the source tarball that was voted on because it has a snapshot version and also a path dependency on DataFusion, so we'll need to fix this for the next release.

On a related note, I'd like the CLI to support Ballista as well, and there is the choice to extend datafusion-cli or create a new ballista-cli. See #886. It would be good to make a decision on approach before we start reserving crate names.

@houqp
Copy link
Member

houqp commented Aug 14, 2021

#885 has datafusion-cli dependency fixed.

@alamb
Copy link
Contributor

alamb commented Aug 15, 2021

I agree that publishing a separate datafusion-cli crate is the way to go here. 👍

@Dandandan
Copy link
Contributor

Yes, agreed 👍

@houqp houqp added this to the 5.1.0 milestone Aug 20, 2021
@jimexist
Copy link
Member

related Homebrew/homebrew-core#88184

@houqp
Copy link
Member

houqp commented Nov 22, 2021

this is now blocked by #1332

@houqp houqp removed this from the 6.0.0 milestone Nov 22, 2021
@jimexist jimexist closed this as completed Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants