Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test coverage for grouping on dictionary encoded columns #8791

Open
alamb opened this issue Jan 8, 2024 · 0 comments
Open

Add test coverage for grouping on dictionary encoded columns #8791

alamb opened this issue Jan 8, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@alamb
Copy link
Contributor

alamb commented Jan 8, 2024

Is your feature request related to a problem or challenge?

At InfluxData we use Dictionary(Int32, Utf8) heavily for certain columns of our queries.

This particular type of data is not well represented in the DataFusion codebase, which leads to issues such as #8738

In addition to not being well covered by functional tests, we also don't have particularly good coverage performance wise, especially for some of our important cases like grouping performance. This leads to dueling speculations on better/worse ways to run such queries, such as #7647 but now good way to evaluate them

Describe the solution you'd like

I would like to ensure we have adequate test coverage

  1. Functional tests so we don't hit regressions accidentally again
  2. Performance tests (e.g. so we could evaluate the changes contemplated by Materialize Dictionaries in Group Keys #7647

Describe alternatives you've considered

I added some functional sqllogictests in

However, those are not reading from Parquet files (as I could not figure out how to make a parquet file have the same schema I wanted)

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant