Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean internal implementation of WindowUDF to use WindowUDFImpl (rather than the function pointers) #8734

Closed
alamb opened this issue Jan 3, 2024 · 1 comment · Fixed by #8746
Closed

Clean internal implementation of WindowUDF to use WindowUDFImpl (rather than the function pointers) #8734

alamb opened this issue Jan 3, 2024 · 1 comment · Fixed by #8746
Labels
enhancement New feature or request

Comments

@alamb
Copy link
Contributor

alamb commented Jan 3, 2024

Is your feature request related to a problem or challenge?

Similiarly to #8712 (see the rationale there)

@guojidan made a trait for creating WindowUDFs (thank you!) -- #8719 but the existing WindowUDF struct still uses function pointers for implementation.

Describe the solution you'd like

I would like to apply the same basic pattern as in #8713 to WindowUDF so that the implementation of WindowUDF is an inner: Arc<WindowUDFImpl> rather than

Describe alternatives you've considered

No response

Additional context

No response
@alamb alamb added the enhancement New feature or request label Jan 3, 2024
This was referenced Jan 3, 2024
Merged
Open
@guojidan
Copy link
Contributor

guojidan commented Jan 3, 2024

I will deal this issue 😄

@guojidan guojidan mentioned this issue Jan 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clean internal implementation of WindowUDF guojidan/arrow-datafusion
2 participants
@alamb @guojidan