Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add serde support for Arrow FileTypeWriterOptions #8599

Closed
andygrove opened this issue Dec 20, 2023 · 2 comments · Fixed by #8850
Closed

Add serde support for Arrow FileTypeWriterOptions #8599

andygrove opened this issue Dec 20, 2023 · 2 comments · Fixed by #8850
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@andygrove
Copy link
Member

Is your feature request related to a problem or challenge?

DataFusion supports many FileTypeWriterOptions:

pub enum FileTypeWriterOptions {
    #[cfg(feature = "parquet")]
    Parquet(ParquetWriterOptions),
    CSV(CsvWriterOptions),
    JSON(JsonWriterOptions),
    Avro(AvroWriterOptions),
    Arrow(ArrowWriterOptions),
}

The serde support in the datafusion-proto crate currently only supports JSON:

message FileTypeWriterOptions {
  oneof FileType {
    JsonWriterOptions json_options = 1;
  }
}

Describe the solution you'd like

Add serde support for Arrow FileTypeWriterOptions

Describe alternatives you've considered

No response

Additional context

No response

@tushushu
Copy link
Contributor

@andygrove Hey, Andy. May I work on this issue?

@alamb
Copy link
Contributor

alamb commented Jan 1, 2024

@andygrove Hey, Andy. May I work on this issue?

Please do -- thank you @tushushu !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants