Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IdentVisitor and GraphvizVisitor pull statistics even when not requested #8513

Closed
vrongmeal opened this issue Dec 12, 2023 · 0 comments · Fixed by #8514
Closed

IdentVisitor and GraphvizVisitor pull statistics even when not requested #8513

vrongmeal opened this issue Dec 12, 2023 · 0 comments · Fixed by #8514
Labels
bug Something isn't working

Comments

@vrongmeal
Copy link
Contributor

Describe the bug

See:

https://github.com/apache/arrow-datafusion/blob/95ba48bd2291dd5c303bdaf88cbb55c79d395930/datafusion/physical-plan/src/display.rs#L263-L266

https://github.com/apache/arrow-datafusion/blob/95ba48bd2291dd5c303bdaf88cbb55c79d395930/datafusion/physical-plan/src/display.rs#L344-L349

They shouldn't be pulled unless requested. Many implementations are simply todo! or error in certain circumstances but need them to work.

To Reproduce

No response

Expected behavior

No response

Additional context

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Pull stats in IdentVisitor/GraphvizVisitor only when requested vrongmeal/arrow-datafusion
1 participant
@vrongmeal