Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show total benchmark time in benchmarks output #8390

Closed
andygrove opened this issue Dec 1, 2023 · 0 comments · Fixed by #8399
Closed

Show total benchmark time in benchmarks output #8390

andygrove opened this issue Dec 1, 2023 · 0 comments · Fixed by #8399
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@andygrove
Copy link
Member

Is your feature request related to a problem or challenge?

Here is the current output from running a comparison of two benchmarks. It shows the change in performance per query but does not provide a summary of the overall performance of the benchmark run.

┏━━━━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query        ┃      main ┃ tweak_batch_size2 ┃        Change ┃
┡━━━━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 1     │ 1495.93ms │         2319.55ms │  1.55x slower │
│ QQuery 2     │  372.33ms │          351.49ms │ +1.06x faster │
│ QQuery 3     │  720.76ms │         1110.36ms │  1.54x slower │
│ QQuery 4     │  833.01ms │          471.11ms │ +1.77x faster │
│ QQuery 5     │ 1759.97ms │         1730.63ms │     no change │
│ QQuery 6     │  247.42ms │          465.09ms │  1.88x slower │
│ QQuery 7     │ 2054.92ms │         2327.30ms │  1.13x slower │
│ QQuery 8     │ 1809.03ms │         1993.64ms │  1.10x slower │
│ QQuery 9     │ 2796.79ms │         3076.88ms │  1.10x slower │
│ QQuery 10    │ 1739.64ms │         1995.19ms │  1.15x slower │
│ QQuery 11    │  315.52ms │          365.86ms │  1.16x slower │
│ QQuery 12    │  663.13ms │          542.66ms │ +1.22x faster │
│ QQuery 13    │  776.61ms │          798.09ms │     no change │
│ QQuery 14    │  464.86ms │          541.58ms │  1.17x slower │
│ QQuery 15    │  745.22ms │         1011.17ms │  1.36x slower │
│ QQuery 16    │  437.82ms │          477.74ms │  1.09x slower │
│ QQuery 17    │ 3237.00ms │         3033.37ms │ +1.07x faster │
│ QQuery 18    │ 3223.49ms │         3296.59ms │     no change │
│ QQuery 19    │  664.84ms │          950.09ms │  1.43x slower │
│ QQuery 20    │ 1072.52ms │         1127.15ms │  1.05x slower │
│ QQuery 21    │ 3144.50ms │         2967.69ms │ +1.06x faster │
│ QQuery 22    │  944.87ms │          545.98ms │ +1.73x faster │
└──────────────┴───────────┴───────────────────┴───────────────┘

Describe the solution you'd like

It would be nice to show the totals as well.

Describe alternatives you've considered

The workaround is to import into a spreadsheet and calculate there.

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant